linux-kernel - Re: [PATCH 0955/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wrfjinvjfi9d.fsf@redhat.com>
Date:	Tue, 02 Aug 2016 08:49:18 -0400
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	Baole Ni <baolex.ni@...el.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0955/1285] Replace numeric parameter like 0444 with macro

Baole Ni <baolex.ni@...el.com> writes:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the
> corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>
> ---
>  drivers/staging/vt6656/main_usb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Excuse me, but why are you CC'ing everybody and their 217 cousins on
these patches?

The fact that someone had a patch applied in a directory close to this
file within the last 3 years is not justification for spamming them with
this.

Jes