lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Aug 2016 08:01:26 -0700 From: Tony Lindgren <tony@...mide.com> To: "H. Nikolaus Schaller" <hns@...delico.com> Cc: Andreas Kemnade <andreas@...nade.info>, Bin Liu <b-liu@...com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Linux USB Mailing List <linux-usb@...r.kernel.org>, linux-omap <linux-omap@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Discussions about the Letux Kernel <letux-kernel@...nphoenux.org> Subject: Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable() * H. Nikolaus Schaller <hns@...delico.com> [160804 07:50]: > > Am 04.08.2016 um 16:29 schrieb Tony Lindgren <tony@...mide.com>: > > > > So I gave this patch a try but it now blocks all deeper SoC idle > > states as the PHY stays active. I think the real fix is to make > > sure the charger behaves independent of the USB PHY state. > > IMHO, plugin detection of the cable is a phy task and then it tells > the charger to start. This part works. OK > Charging did work up to kernel 4.3. It started to fail with 4.4-rc1 > without obvious changes to the charger but many patches to phy > and musb. We had even backported the 4.7 charger driver > to 4.3 and it failed as well. OK > > So > > probably this needs to be fixed in phy-twl4030-usb.c and > > twl4030_charger.c instead. Now it sounds like we're also shutting > > down the charger with the USB PHY. > > As a very deeply hidden side-effect the charger is shut down immediately > after being started. Because phy-twl4030-usb.c does not do what it is expected > and told to do. > > I have developed a workaround for the charger driver but I do not consider it > as the solution. > > http://git.goldelico.com/?p=gta04-kernel.git;a=commit;h=b8c538e75c6dd034889bdb0d66e00ca6e128e616 ... > With that we have a workaround in the charger, but not a correct solution. > That is what Andreas is trying to fix. The charger driver seems to be ok to > me. OK. So does the charger work with just phy-twl4030-usb and charger modules loaded when cable is inserted? Regards, Tony
Powered by blists - more mailing lists