linux-kernel - [PATCH 4/4] misc: tifm: use complete() instead of complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1470389163-4594-5-git-send-email-wagi@monom.org>
Date:	Fri,  5 Aug 2016 11:26:03 +0200
From:	Daniel Wagner <wagi@...om.org>
To:	linux-kernel@...r.kernel.org
Cc:	Alex Dubov <oakad@...oo.com>,
	Ashutosh Dixit <ashutosh.dixit@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sudeep Dutt <sudeep.dutt@...el.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Daniel Wagner <daniel.wagner@...-carit.de>
Subject: [PATCH 4/4] misc: tifm: use complete() instead of complete_all()

From: Daniel Wagner <daniel.wagner@...-carit.de>

There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().

The usage pattern of the completion is:

waiter context                          waker context

tifm_7xx1_resume()
  DECLARE_COMPLETION_ONSTACK(finish_resume)
  fm->finish_me = finish_resume
  /* enable irq */
  wait_for_completion_timeout(finish_resume)

                                        tifm_7xx1_isr()
                                          complete(fm->finish_me)

Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de>
---
 drivers/misc/tifm_7xx1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/tifm_7xx1.c b/drivers/misc/tifm_7xx1.c
index a37a42f..77af41c 100644
--- a/drivers/misc/tifm_7xx1.c
+++ b/drivers/misc/tifm_7xx1.c
@@ -69,7 +69,7 @@ static irqreturn_t tifm_7xx1_isr(int irq, void *dev_id)
 	writel(irq_status, fm->addr + FM_INTERRUPT_STATUS);
 
 	if (fm->finish_me)
-		complete_all(fm->finish_me);
+		complete(fm->finish_me);
 	else if (!fm->socket_change_set)
 		writel(TIFM_IRQ_ENABLE, fm->addr + FM_SET_INTERRUPT_ENABLE);
 	else
-- 
2.7.4