linux-kernel - [PATCH 3/4] misc: ti-st: use complete() instead of complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri,  5 Aug 2016 11:26:02 +0200
From:	Daniel Wagner <wagi@...om.org>
To:	linux-kernel@...r.kernel.org
Cc:	Alex Dubov <oakad@...oo.com>,
	Ashutosh Dixit <ashutosh.dixit@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sudeep Dutt <sudeep.dutt@...el.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Daniel Wagner <daniel.wagner@...-carit.de>
Subject: [PATCH 3/4] misc: ti-st: use complete() instead of complete_all()

From: Daniel Wagner <daniel.wagner@...-carit.de>

There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().

The usage pattern of the completion is:

waiter context                          waker context

read_local_version()
  reinit_completion()
  st_int_write()
  wait_for_completion_interruptible_timeout()

                                        validate_firmware_response()
                                          complete()
  reinit_completion()

Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de>
---
 drivers/misc/ti-st/st_kim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c
index bf0d770..0e1c94a 100644
--- a/drivers/misc/ti-st/st_kim.c
+++ b/drivers/misc/ti-st/st_kim.c
@@ -88,7 +88,7 @@ static void validate_firmware_response(struct kim_data_s *kim_gdata)
 		return;		/* keep waiting for the proper response */
 	}
 	/* becos of all the script being downloaded */
-	complete_all(&kim_gdata->kim_rcvd);
+	complete(&kim_gdata->kim_rcvd);
 	kfree_skb(skb);
 }
 
-- 
2.7.4