linux-kernel - [PATCH 2/4] misc: mic: vop: use complete() instead of complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1470389163-4594-3-git-send-email-wagi@monom.org>
Date:	Fri,  5 Aug 2016 11:26:01 +0200
From:	Daniel Wagner <wagi@...om.org>
To:	linux-kernel@...r.kernel.org
Cc:	Alex Dubov <oakad@...oo.com>,
	Ashutosh Dixit <ashutosh.dixit@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sudeep Dutt <sudeep.dutt@...el.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Daniel Wagner <daniel.wagner@...-carit.de>
Subject: [PATCH 2/4] misc: mic: vop: use complete() instead of complete_all()

From: Daniel Wagner <daniel.wagner@...-carit.de>

There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().

The usage pattern of the completion is:

waiter context                          waker context

_vop_remove_device()
  reinit_completion()
  wait_for_completion()
                                        vop_reset()
                                          complete()

Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de>
---
 drivers/misc/mic/vop/vop_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/mic/vop/vop_main.c b/drivers/misc/mic/vop/vop_main.c
index 1a2b67f3..f4ed4a8 100644
--- a/drivers/misc/mic/vop/vop_main.c
+++ b/drivers/misc/mic/vop/vop_main.c
@@ -229,7 +229,7 @@ static void vop_reset(struct virtio_device *dev)
 		__func__, dev->id.device);
 
 	vop_reset_inform_host(dev);
-	complete_all(&vdev->reset_done);
+	complete(&vdev->reset_done);
 }
 
 /*
-- 
2.7.4