linux-kernel - Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1470399762.2977.40.camel@sipsolutions.net>
Date:	Fri, 05 Aug 2016 14:22:42 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Maxim Altshul <maxim.altshul@...com>, linux-kernel@...r.kernel.org
Cc:	john.stultz@...aro.org, Kalle Valo <kvalo@...eaurora.org>,
	Eliad Peller <eliad@...ery.com>, Yaniv Machani <yanivma@...com>
Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to
 get_expected_throughput

On Thu, 2016-08-04 at 15:43 +0300, Maxim Altshul wrote:
> - The variable is added to allow the driver an easy access
> to it's own hw->priv when the op is invoked.
> 
> - Change wlcore op accordingly.
> 
I'm applying this now, with a big BUT:

1) your changelog is crap - I've rewritten it to indicate what's going
on

2) I think the change makes sense, but as far as fixing the bug is
concerned it's actually completely stupid

3) I expect you to submit a proper bugfix for mac80211 ASAP, to not
call into the driver before the station is actually known to the
driver.

johannes