linux-kernel - Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLU_=1hvpneB+LMe51J5YQh0LdhYo=V5=UwDBAU1Zp-Lbg@mail.gmail.com>
Date:	Thu, 4 Aug 2016 23:03:29 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Maxim Altshul <maxim.altshul@...com>,
	lkml <linux-kernel@...r.kernel.org>,
	Kalle Valo <kvalo@...eaurora.org>,
	Eliad Peller <eliad@...ery.com>, Yaniv Machani <yanivma@...com>
Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput

On Thu, Aug 4, 2016 at 10:40 PM, Johannes Berg
<johannes@...solutions.net> wrote:
> On Thu, 2016-08-04 at 14:31 -0700, John Stultz wrote:
>> On Thu, Aug 4, 2016 at 5:43 AM, Maxim Altshul <maxim.altshul@...com>
>> wrote:
>> > - The variable is added to allow the driver an easy access
>> > to it's own hw->priv when the op is invoked.
>> >
>> > - Change wlcore op accordingly.
>> >
>> > Signed-off-by: Maxim Altshul <maxim.altshul@...com>
>>
>> These two patches solve the regression I was seeing with pre-v4.8-rc1
>> kernels on HiKey.
>>
>
> Interesting, what was the regression? Was the station pointer there not
> valid?

Yea, a null pointer deference:
https://lkml.org/lkml/2016/7/27/712

thanks
-john