linux-kernel - Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Aug 2016 17:54:42 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>, jolsa@...nel.org,
	Ingo Molnar <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Subject: Re: [PATCH V3 1/6] perf/core: Adding PMU driver specific
 configuration

On Fri, Aug 05, 2016 at 09:41:15AM -0600, Mathieu Poirier wrote:
> On 4 August 2016 at 10:59, Peter Zijlstra <peterz@...radead.org> wrote:
> > On Thu, Jul 28, 2016 at 03:42:18PM -0600, Mathieu Poirier wrote:
> >> This patch somewhat mimics the work done on address filters to
> >> add the infrastructure needed to pass PMU specific HW
> >> configuration to the driver before a session starts.
> >
> > I'm thinking we want to specify a syntax and validate the string matches
> > the syntax in the generic code.
> 
> The syntax is checked in the lexer making sure that nothing other than
> @cfg or @cfg=config is sent to the kernel.  From there validation is
> done in the PMU driver that implements the set_drv_configs()
> interface.
> 
> I am not sure to get you point here - can I ask you to provide more details?

What keeps random userspace from sending malformed strings in? There's
more userspace than just the perf tool.

The kernel needs to validate structure.