linux-kernel - Re: [PATCH 3/6] fs: befs: remove useless initialization to zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160806183638.GC3423@pc>
Date:	Sat, 6 Aug 2016 19:36:38 +0100
From:	Salah Triki <salah.triki@...il.com>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	akpm@...ux-foundation.org, viro@...iv.linux.org.uk,
	mhocko@...e.com, vdavydov@...tuozzo.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] fs: befs: remove useless initialization to zero

On Mon, Aug 01, 2016 at 02:44:18PM +0100, Luis de Bethencourt wrote:
> On 31/07/16 21:34, Salah Triki wrote:
> > node_off is unconditionally set to bt_super.root_node_ptr, so no need to
> > init it to zero.
> > 
> > Signed-off-by: Salah Triki <salah.triki@...il.com>
> > ---
> >  fs/befs/btree.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/befs/btree.c b/fs/befs/btree.c
> > index f33fc6c..3cb97e8 100644
> > --- a/fs/befs/btree.c
> > +++ b/fs/befs/btree.c
> > @@ -420,7 +420,7 @@ befs_btree_read(struct super_block *sb, const befs_data_stream *ds,
> >  {
> >  	struct befs_btree_node *this_node;
> >  	befs_btree_super bt_super;
> > -	befs_off_t node_off = 0;
> > +	befs_off_t node_off;
> >  	int cur_key;
> >  	fs64 *valarray;
> >  	char *keystart;
> > 
> 
> Looks good to me.
> 
> Strange that static analysis didn't pick this one up before.
> 
> Acked-by: Luis de Bethencourt <luisbg@....samsung.com>
> 
> Pushed to the befs-next branch:
> https://github.com/luisbg/linux-befs/tree/befs-next
> 
> Thanks Salah,
> Luis

Thanx :)
Salah