lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 06 Aug 2016 04:04:32 +0200 From: Michal Nazarewicz <mina86@...a86.com> To: "Felipe F. Tonello" <eu@...ipetonello.com>, linux-usb@...r.kernel.org Cc: linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...nel.org> Subject: Re: [PATCH v3 4/9] usb: gadget: f_midi: defaults buflen sizes to 512 On Fri, Aug 05 2016, Felipe F. Tonello wrote: > 512 is the value used by wMaxPacketSize, as specified by the USB Spec. This > makes sure this driver uses, by default, the most optimal value for IN and OUT > endpoint requests. > > Signed-off-by: Felipe F. Tonello <eu@...ipetonello.com> Acked-by: Michal Nazarewicz <mina86@...a86.com> > --- > drivers/usb/gadget/function/f_midi.c | 2 +- > drivers/usb/gadget/legacy/gmidi.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c > index 39018dea7035..a7b50ac947f8 100644 > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -1122,7 +1122,7 @@ static struct usb_function_instance *f_midi_alloc_inst(void) > opts->func_inst.free_func_inst = f_midi_free_inst; > opts->index = SNDRV_DEFAULT_IDX1; > opts->id = SNDRV_DEFAULT_STR1; > - opts->buflen = 256; > + opts->buflen = 512; > opts->qlen = 32; > opts->in_ports = 1; > opts->out_ports = 1; > diff --git a/drivers/usb/gadget/legacy/gmidi.c b/drivers/usb/gadget/legacy/gmidi.c > index fc2ac150f5ff..0bf39c3ccdb1 100644 > --- a/drivers/usb/gadget/legacy/gmidi.c > +++ b/drivers/usb/gadget/legacy/gmidi.c > @@ -47,7 +47,7 @@ static char *id = SNDRV_DEFAULT_STR1; > module_param(id, charp, S_IRUGO); > MODULE_PARM_DESC(id, "ID string for the USB MIDI Gadget adapter."); > > -static unsigned int buflen = 256; > +static unsigned int buflen = 512; > module_param(buflen, uint, S_IRUGO); > MODULE_PARM_DESC(buflen, "MIDI buffer length"); > > -- > 2.9.0 > -- Best regards ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ «If at first you don’t succeed, give up skydiving»
Powered by blists - more mailing lists