linux-kernel - Re: [PATCH v4 0/6] power: add power sequence library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 06 Aug 2016 14:00:08 +0200
From:	Oscar <oscar@...andei.net>
To:	Peter Chen <peter.chen@....com>
Cc:	<gregkh@...uxfoundation.org>, <stern@...land.harvard.edu>,
	<ulf.hansson@...aro.org>, <broonie@...nel.org>, <sre@...nel.org>,
	<robh+dt@...nel.org>, <shawnguo@...nel.org>,
	<dbaryshkov@...il.com>, <dwmw3@...radead.org>,
	<k.kozlowski@...sung.com>, <linux-arm-kernel@...ts.infradead.org>,
	<p.zabel@...gutronix.de>, <devicetree@...r.kernel.org>,
	<pawel.moll@....com>, <mark.rutland@....com>,
	<linux-usb@...r.kernel.org>, <arnd@...db.de>,
	<s.hauer@...gutronix.de>, <mail@...iej.szmigiero.name>,
	<troy.kisky@...ndarydevices.com>, <festevam@...il.com>,
	<stephen.boyd@...aro.org>, <linux-pm@...r.kernel.org>,
	<stillcompiling@...il.com>, <linux-kernel@...r.kernel.org>,
	<mka@...omium.org>
Subject: Re: [PATCH v4 0/6] power: add power sequence library

El 2016-08-02 05:30, Peter Chen escribió:
> Hi all,
>
> This is a follow-up for my last power sequence framework patch set 
> [1].
> According to Rob Herring and Ulf Hansson's comments[2], I use a 
> generic
> power sequence library for parsing the power sequence elements on DT,
> and implement generic power sequence on library. The host driver
> can allocate power sequence instance, and calls pwrseq APIs 
> accordingly.
>
> In future, if there are special power sequence requirements, the 
> special
> power sequence library can be created.
>
> This patch set is tested on i.mx6 sabresx evk using a dts change, I 
> use
> two hot-plug devices to simulate this use case, the related binding
> change is updated at patch [1/6], The udoo board changes were tested
> using my last power sequence patch set.[3]
>
> Except for hard-wired MMC and USB devices, I find the USB ULPI PHY 
> also
> need to power on itself before it can be found by ULPI bus.
>
> [1] http://www.spinics.net/lists/linux-usb/msg142755.html
> [2] http://www.spinics.net/lists/linux-usb/msg143106.html
> [3] http://www.spinics.net/lists/linux-usb/msg142815.html
>
> Changes for v4:
> - Create the patch on next-20160722
> - Fix the of_node is not NULL after chipidea driver is unbinded 
> [Patch 5/6]
> - Using more friendly wait method for reset gpio [Patch 2/6]
> - Support multiple input clocks [Patch 2/6]
> - Add Rob Herring's ack for DT changes
> - Add Joshua Clayton's Tested-by
>
> Changes for v3:
> - Delete "power-sequence" property at binding-doc, and change related 
> code
>   at both library and user code.
> - Change binding-doc example node name with Rob's comments
> - of_get_named_gpio_flags only gets the gpio, but without setting 
> gpio flags,
>   add additional code request gpio with proper gpio flags
> - Add Philipp Zabel's Ack and MAINTAINER's entry
>
> Changes for v2:
> - Delete "pwrseq" prefix and clock-names for properties at dt binding
> - Should use structure not but its pointer for kzalloc
> - Since chipidea core has no of_node, let core's of_node equals glue
>   layer's at core's probe
>
> Peter Chen (6):
>   binding-doc: power: pwrseq-generic: add binding doc for generic 
> power
>     sequence library
>   power: add power sequence library
>   binding-doc: usb: usb-device: add optional properties for power
>     sequence
>   usb: core: add power sequence handling for USB devices
>   usb: chipidea: let chipidea core device of_node equal's glue layer
>     device of_node
>   ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property
>

Hi Peter,

I tried the last version on my udoo board but I got these compile 
errors:

[21330s] ERROR: "pwrseq_get" [drivers/usb/core/usbcore.ko] undefined!
[21330s] ERROR: "pwrseq_free" [drivers/usb/core/usbcore.ko] undefined!
[21330s] ERROR: "pwrseq_put" [drivers/usb/core/usbcore.ko] undefined!
[21330s] ERROR: "pwrseq_off" [drivers/usb/core/usbcore.ko] undefined!
[21330s] ERROR: "pwrseq_on" [drivers/usb/core/usbcore.ko] undefined!

Will you do another version?

Thanks!
--
Oscar