linux-kernel - Re: [PATCH v3] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fc7f1af-b66d-3089-8c15-6cdc570ac159@users.sourceforge.net>
Date:	Sat, 6 Aug 2016 08:30:29 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	Amitoj Kaur Chawla <amitoj1606@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Coccinelle <cocci@...teme.lip6.fr>,
	Gilles Muller <Gilles.Muller@...6.fr>,
	Julia Lawall <julia.lawall@...6.fr>,
	Michal Marek <mmarek@...e.com>,
	Nicolas Palix <nicolas.palix@...g.fr>
Subject: Re: [PATCH v3] Coccinelle: Script to replace NULL test with IS_ERR
 test for devm_ioremap_resource

> +@err depends on context || org || report@
> +statement S;
> +expression e;
> +position j0;

How do you think about to omit the number from this variable name?


> +@@
> +
> +  e = devm_ioremap_resource(...);
> +* if (!e@j0) S

Are there any more functions to consider for such a source code search pattern?
How do you think about to use a function name list here?


> +// ----------------------------------------------------------------------------

I suggest to omit such comment lines from this SmPL script.

Regards,
Markus