linux-kernel - Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing RFXE bit in HID1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Aug 2016 05:06:39 +0000
From:	york sun <york.sun@....com>
To:	Borislav Petkov <bp@...en8.de>
CC:	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"morbidrsa@...il.com" <morbidrsa@...il.com>,
	"oss@...error.net" <oss@...error.net>,
	Stuart Yoder <stuart.yoder@....com>,
	Doug Thompson <dougthompson@...ssion.com>,
	"mchehab@...nel.org" <mchehab@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing
 RFXE bit in HID1

On 08/08/2016 10:01 PM, Borislav Petkov wrote:
> On Tue, Aug 09, 2016 at 04:31:19AM +0000, york sun wrote:
>> Yes, for most SoCs RFXE remains cleared. Uncorrectable errors are
>> handled by EDAC.
>
> And how is mpc85_xxx EDAC handling them?
>
> mpc85xx_mc_check() only reports them.

Correct. It can only report this kind of error. It is not correctable. 
Nothing more can be done.

>
> And now to get to my original question: is it *enough* to report
> uncorrectable errors on those platforms or do they need more
> sophisticated error handling in order to disable data corruption?
>

It is uncorrectable. DDR controller can only report the error. I don't 
believe EDAC driver can do more. For the same reason I said we can leave 
RXFE as is, even for e500v1 case (with RIO or PCI is enabled). Nothing 
can be done with uncorrectable error.

York