linux-kernel - Re: drivers/usb/usbip/vudc_rx.c:145: possible bad bitmask ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Aug 2016 16:09:40 +0200
From:	Greg KH <gregkh@...uxfoundation.org>
To:	David Binderman <linuxdev.baldrick@...il.com>
Cc:	valentina.manea.m@...il.com, shuahkh@....samsung.com,
	linux-usb@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	dcb314@...mail.com
Subject: Re: drivers/usb/usbip/vudc_rx.c:145: possible bad bitmask ?

On Mon, Jul 18, 2016 at 01:29:05PM +0100, David Binderman wrote:
> Hello there,
> 
> drivers/usb/usbip/vudc_rx.c:145:27: warning: result of ‘11 << 30’
> requires 35 bits to represent, but ‘int’ only has 32 bits
> [-Wshift-overflow=]
> 
> Source code is
> 
>     urb_p->urb->pipe &= ~(11 << 30);
> 
> Maybe better code
> 
>     urb_p->urb->pipe &= ~(11UL << 30);

Perhaps, care to send a patch?

thanks,

greg k-h