linux-kernel - drivers/usb/usbip/vudc_rx.c:145: possible bad bitmask ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMzoamaxBaezxvEw3x6rgPLmYZ6xEhZjbxg=_3-LzEKDdBJ5xw@mail.gmail.com>
Date:	Mon, 18 Jul 2016 13:29:05 +0100
From:	David Binderman <linuxdev.baldrick@...il.com>
To:	valentina.manea.m@...il.com, shuahkh@....samsung.com,
	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	dcb314@...mail.com
Subject: drivers/usb/usbip/vudc_rx.c:145: possible bad bitmask ?

Hello there,

drivers/usb/usbip/vudc_rx.c:145:27: warning: result of ‘11 << 30’
requires 35 bits to represent, but ‘int’ only has 32 bits
[-Wshift-overflow=]

Source code is

    urb_p->urb->pipe &= ~(11 << 30);

Maybe better code

    urb_p->urb->pipe &= ~(11UL << 30);

Regards

David Binderman