linux-kernel - Re: [PATCH 1/2] of/irq: Mark interrupt controllers as populated before initialisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <236546c6-35f8-4a51-1a71-120cabd55563@nvidia.com>
Date:	Tue, 9 Aug 2016 17:30:20 +0100
From:	Jon Hunter <jonathanh@...dia.com>
To:	Philipp Zabel <p.zabel@...gutronix.de>,
	Rob Herring <robh@...nel.org>, <linux-kernel@...r.kernel.org>
CC:	Shawn Guo <shawnguo@...nel.org>,
	Fabio Estevam <fabio.estevam@....com>,
	<linux-arm-kernel@...ts.infradead.org>, <kernel@...gutronix.de>
Subject: Re: [PATCH 1/2] of/irq: Mark interrupt controllers as populated
 before initialisation


On 09/08/16 15:18, Philipp Zabel wrote:
> That way the init callback may clear the flag again, in case of drivers
> split between early irq chip and a normal platform driver.
> 
> Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated")
> Suggested-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Jon Hunter <jonathanh@...dia.com>
> ---
>  drivers/of/irq.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index 89a71c6..a2e68f7 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -544,12 +544,15 @@ void __init of_irq_init(const struct of_device_id *matches)
>  
>  			list_del(&desc->list);
>  
> +			of_node_set_flag(desc->dev, OF_POPULATED);
> +
>  			pr_debug("of_irq_init: init %s (%p), parent %p\n",
>  				 desc->dev->full_name,
>  				 desc->dev, desc->interrupt_parent);
>  			ret = desc->irq_init_cb(desc->dev,
>  						desc->interrupt_parent);
>  			if (ret) {
> +				of_node_clear_flag(desc->dev, OF_POPULATED);
>  				kfree(desc);
>  				continue;
>  			}
> @@ -559,8 +562,6 @@ void __init of_irq_init(const struct of_device_id *matches)
>  			 * its children can get processed in a subsequent pass.
>  			 */
>  			list_add_tail(&desc->list, &intc_parent_list);
> -
> -			of_node_set_flag(desc->dev, OF_POPULATED);
>  		}
>  
>  		/* Get the next pending parent that might have children */
> 

Acked-by: Jon Hunter <jonathanh@...dia.com>

Cheers
Jon

-- 
nvpublic