linux-kernel - Re: [PATCH v1 1/2] x86/KASLR: Fix physical memory calculation on KASLR memory randomization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJcbSZFM6gqUFL2o74AEQqf=jrATgP0cYhgVNVLC0iw+L4YOMQ@mail.gmail.com>
Date:	Tue, 9 Aug 2016 09:30:41 -0700
From:	Thomas Garnier <thgarnie@...gle.com>
To:	Joerg Roedel <jroedel@...e.de>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H . Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...e.de>,
	Dave Young <dyoung@...hat.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
	Lv Zheng <lv.zheng@...el.com>, Baoquan He <bhe@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Mark Salter <msalter@...hat.com>,
	Aleksey Makarov <aleksey.makarov@...aro.org>,
	Kees Cook <keescook@...omium.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Christian Borntraeger <borntraeger@...ibm.com>,
	Fabian Frederick <fabf@...net.be>,
	Toshi Kani <toshi.kani@...com>,
	Dan Williams <dan.j.williams@...el.com>,
	"the arch/x86 maintainers" <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Kernel Hardening <kernel-hardening@...ts.openwall.com>
Subject: Re: [PATCH v1 1/2] x86/KASLR: Fix physical memory calculation on
 KASLR memory randomization

On Tue, Aug 9, 2016 at 9:03 AM, Joerg Roedel <jroedel@...e.de> wrote:
> On Tue, Aug 09, 2016 at 09:00:04AM -0700, Thomas Garnier wrote:
>> On Mon, Aug 8, 2016 at 11:40 AM, Thomas Garnier <thgarnie@...gle.com> wrote:
>> > Initialize KASLR memory randomization after max_pfn is initialized. Also
>> > ensure the size is rounded up. Could have create problems on machines
>> > with more than 1Tb of memory on certain random addresses.
>> >
>> > Signed-off-by: Thomas Garnier <thgarnie@...gle.com>
>>
>> I will send a new version of this PATCH soon. The test bot found
>> places where virtual addresses were computed before PAGE_OFFSET was
>> set. I will investigate that.
>
> When you do that, please also add 'Fixes:' tags to your patches.
>

Will do.

> Thanks,
>
>         Joerg
>