linux-kernel - Re: [PATCH] max17042_battery: fix model download bug.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <6db1eb24-d659-e424-9da7-39cabd6ad5ee@samsung.com>
Date:	Wed, 10 Aug 2016 10:27:07 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Sebastian Reichel <sre@...nel.org>,
	Sven Van Asbroeck <thesven73@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	Jonghwa Lee <jonghwa3.lee@...sung.com>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] max17042_battery: fix model download bug.

On 08/09/2016 08:54 PM, Sebastian Reichel wrote:
> Hi,
> 
> [adding some people to CC]
> 
> On Wed, Aug 03, 2016 at 10:03:46AM -0400, Sven Van Asbroeck wrote:
>> The device's model download function returns the model data as
>> an array of u32s, which is later compared to the reference
>> model data. However, since the latter is an array of u16s,
>> the comparison does not happen correctly, and model verification
>> fails. This in turn breaks the POR initialization sequence.
> 
> Patch looks ok, except for missing Fixes. I guess it should be
> "Fixes: 39e7213edc4f3". I will wait with queuing it for a few
> days giving Samsung people a chance to reply.

Looks correct.
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Also:
Cc: <stable@...r.kernel.org>

And how about:
Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
https://www.marc.info/?l=linux-pm&m=143954612610000&w=4

Best regards,
Krzysztof