linux-kernel - Re: [PATCH] max17042_battery: fix model download bug.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160812005949.GA8531@earth>
Date:	Fri, 12 Aug 2016 02:59:49 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Sven Van Asbroeck <thesven73@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] max17042_battery: fix model download bug.

Hi Sven,

On Wed, Aug 03, 2016 at 10:03:46AM -0400, Sven Van Asbroeck wrote:
> The device's model download function returns the model data as
> an array of u32s, which is later compared to the reference
> model data. However, since the latter is an array of u16s,
> the comparison does not happen correctly, and model verification
> fails. This in turn breaks the POR initialization sequence.

It looks like your mail software broke the patch format.

Applying: max17042_battery: fix model download bug.
fatal: corrupt patch at line 10
Patch failed at 0001 max17042_battery: fix model download bug.

I can see, that at least the tabs were replaced with spaces.  Please
send again with this fixed and while you touch the patch anyways add
the the tags Krzysztof and I mentioned in this thread.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)