linux-kernel - Re: [PATCH 1/1] xilinx: check return value of class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 10 Aug 2016 11:29:13 +0200
From:	Michal Simek <michal.simek@...inx.com>
To:	<yizhouzhou@....ac.cn>, <michal.simek@...inx.com>,
	<soren.brinkmann@...inx.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
CC:	Zhouyi Zhou <zhouzhouyi@...il.com>
Subject: Re: [PATCH 1/1] xilinx: check return value of class_create

On 10.8.2016 10:08, yizhouzhou@....ac.cn wrote:
> From: Zhouyi Zhou <yizhouzhou@....ac.cn>
> 
> 	 return value of class_create should be considered in
> module init function.
> 
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@...il.com>
> ---
>  drivers/char/xilinx_hwicap/xilinx_hwicap.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xilinx_hwicap/xilinx_hwicap.c
> index c07dfe5..3877b46 100644
> --- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c
> +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c
> @@ -854,6 +854,9 @@ static int __init hwicap_module_init(void)
>  	int retval;
>  
>  	icap_class = class_create(THIS_MODULE, "xilinx_config");
> +	if (IS_ERR(icap_class))
> +		return PTR_ERR(icap_class);
> +
>  	mutex_init(&icap_sem);
>  
>  	devt = MKDEV(XHWICAP_MAJOR, XHWICAP_MINOR);
> 

Acked-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal