linux-kernel - Re: [PATCH] w1: fix timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Aug 2016 23:00:35 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Wei Yongjun <weiyj.lk@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] w1: fix timeout_us parameter description

Hi

10.08.2016, 06:22, "Wei Yongjun" <weiyj.lk@...il.com>:
>>  08.08.2016, 16:52, "Wei Yongjun" <weiyj.lk@...il.com>:
>>>  Fix 'timeout_us' parameter description.

>>>   MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches");
>>>   module_param_named(timeout_us, w1_timeout_us, int, 0);
>>>  -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
>>>  - " searches");
>>>  +MODULE_PARM_DESC(timeout_us,
>>>  + "time in microseconds between automatic slave searches");
>>  I believe there will be no harm to put it to on one line, even if it crosses some obscure very-long-line rule
>
> Maybe the bad patch description confused you, this patch the typo in the
> first argument of MODULE_PARM_DESC(), use timeout_us instead of timeout.

Yup, you are right, please make it as one line since you are at it