lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Aug 2016 11:42:19 +0800 From: "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com> To: Hanjun Guo <guohanjun@...wei.com>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, linux-kernel <linux-kernel@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>, "Frank Rowand" <frowand.list@...il.com>, devicetree <devicetree@...r.kernel.org> CC: Zefan Li <lizefan@...wei.com>, Xinwei Hu <huxinwei@...wei.com>, "Tianhong Ding" <dingtianhong@...wei.com> Subject: Re: [PATCH v5 03/14] arm64/numa: add nid check for memory block On 2016/8/10 10:12, Hanjun Guo wrote: > On 2016/8/8 17:18, Zhen Lei wrote: >> Use the same tactic to cpu and numa-distance nodes. >> >> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com> >> --- >> arch/arm64/mm/numa.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c >> index c7fe3ec..2601660 100644 >> --- a/arch/arm64/mm/numa.c >> +++ b/arch/arm64/mm/numa.c >> @@ -141,6 +141,11 @@ int __init numa_add_memblk(int nid, u64 start, u64 end) >> { >> int ret; >> >> + if (nid >= MAX_NUMNODES) { >> + pr_warn("NUMA: Node id %u exceeds maximum value\n", nid); >> + return -EINVAL; >> + } > > I think this check should be added to of_numa_parse_memory_nodes(), which before > the numa_add_memblk() called, it's the same logic in of_numa_parse_cpu_nodes() and > the node id is checked before calling numa_add_memblk() in ACPI. Yes, you are right. This check is arch independent. > > Thanks > Hanjun > > > > . >
Powered by blists - more mailing lists