linux-kernel - Re: [PATCH 3/4] befs: fix comment style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160810214236.GB4372@pc>
Date:	Wed, 10 Aug 2016 22:42:36 +0100
From:	Salah Triki <salah.triki@...il.com>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	viro@...iv.linux.org.uk, salah.triki@....org
Subject: Re: [PATCH 3/4] befs: fix comment style

On Tue, Aug 09, 2016 at 11:01:25PM +0100, Luis de Bethencourt wrote:
> The description of befs_load_sb was confusing the kernel-doc system since,
> because it starts with /**, it thinks it will document the function with
> kernel-doc formatting. Which it isn't.
> 
> Fix other comment style issues in the file while we are at it.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
>  fs/befs/super.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/befs/super.c b/fs/befs/super.c
> index c36745d..80b93c0 100644
> --- a/fs/befs/super.c
> +++ b/fs/befs/super.c
> @@ -13,13 +13,9 @@
>  #include "befs.h"
>  #include "super.h"
>  
> -/**
> +/*
>   * befs_load_sb -- Read from disk and properly byteswap all the fields
>   * of the befs superblock
> - *
> - *
> - *
> - *
>   */
>  int
>  befs_load_sb(struct super_block *sb, befs_super_block * disk_sb)
> @@ -93,8 +89,8 @@ befs_check_sb(struct super_block *sb)
>  	}
>  
>  	/*
> -	   * block_shift and block_size encode the same information
> -	   * in different ways as a consistency check.
> +	 * block_shift and block_size encode the same information
> +	 * in different ways as a consistency check.
>  	 */
>  
>  	if ((1 << befs_sb->block_shift) != befs_sb->block_size) {
> -- 
> 2.5.1
> 

Signed-off-by: Salah Triki <salah.triki@...il.com>

Thanx
Salah