linux-kernel - Re: [PATCH 4/4] befs: fix style issues in super.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160810214448.GC4372@pc>
Date:	Wed, 10 Aug 2016 22:44:48 +0100
From:	Salah Triki <salah.triki@...il.com>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	viro@...iv.linux.org.uk, salah.triki@....org
Subject: Re: [PATCH 4/4] befs: fix style issues in super.c

On Tue, Aug 09, 2016 at 11:01:26PM +0100, Luis de Bethencourt wrote:
> Fixing the following checkpatch.pl error:
> 
> ERROR: "foo * bar" should be "foo *bar"
> +befs_load_sb(struct super_block *sb, befs_super_block * disk_sb)
> 
> And the following warnings:
> 
> WARNING: suspect code indent for conditional statements (8, 12)
> +       if (disk_sb->fs_byte_order == BEFS_BYTEORDER_NATIVE_LE)
> +           befs_sb->byte_order = BEFS_BYTESEX_LE;
> 
> WARNING: suspect code indent for conditional statements (8, 12)
> +       else if (disk_sb->fs_byte_order == BEFS_BYTEORDER_NATIVE_BE)
> +           befs_sb->byte_order = BEFS_BYTESEX_BE;
> 
> WARNING: break quoted strings at a space character
> +               befs_error(sb, "blocksize(%u) cannot be larger"
> +                          "than system pagesize(%lu)", befs_sb->block_size,
> 
> WARNING: line over 80 characters
> +       if (befs_sb->log_start != befs_sb->log_end || befs_sb->flags == BEFS_DIRTY) {
> 
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
> 
> Fixing these because I was touching this code area.
> 
> Thanks,
> Luis
> 
>  fs/befs/super.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/befs/super.c b/fs/befs/super.c
> index 80b93c0..7c50025 100644
> --- a/fs/befs/super.c
> +++ b/fs/befs/super.c
> @@ -18,15 +18,15 @@
>   * of the befs superblock
>   */
>  int
> -befs_load_sb(struct super_block *sb, befs_super_block * disk_sb)
> +befs_load_sb(struct super_block *sb, befs_super_block *disk_sb)
>  {
>  	struct befs_sb_info *befs_sb = BEFS_SB(sb);
>  
>  	/* Check the byte order of the filesystem */
>  	if (disk_sb->fs_byte_order == BEFS_BYTEORDER_NATIVE_LE)
> -	    befs_sb->byte_order = BEFS_BYTESEX_LE;
> +		befs_sb->byte_order = BEFS_BYTESEX_LE;
>  	else if (disk_sb->fs_byte_order == BEFS_BYTEORDER_NATIVE_BE)
> -	    befs_sb->byte_order = BEFS_BYTESEX_BE;
> +		befs_sb->byte_order = BEFS_BYTESEX_BE;
>  
>  	befs_sb->magic1 = fs32_to_cpu(sb, disk_sb->magic1);
>  	befs_sb->magic2 = fs32_to_cpu(sb, disk_sb->magic2);
> @@ -82,7 +82,7 @@ befs_check_sb(struct super_block *sb)
>  	}
>  
>  	if (befs_sb->block_size > PAGE_SIZE) {
> -		befs_error(sb, "blocksize(%u) cannot be larger"
> +		befs_error(sb, "blocksize(%u) cannot be larger "
>  			   "than system pagesize(%lu)", befs_sb->block_size,
>  			   PAGE_SIZE);
>  		return BEFS_ERR;
> @@ -106,10 +106,11 @@ befs_check_sb(struct super_block *sb)
>  	if ((1 << befs_sb->ag_shift) != befs_sb->blocks_per_ag)
>  		befs_error(sb, "ag_shift disagrees with blocks_per_ag.");
>  
> -	if (befs_sb->log_start != befs_sb->log_end || befs_sb->flags == BEFS_DIRTY) {
> +	if (befs_sb->log_start != befs_sb->log_end ||
> +	    befs_sb->flags == BEFS_DIRTY) {
>  		befs_error(sb, "Filesystem not clean! There are blocks in the "
> -			   "journal. You must boot into BeOS and mount this volume "
> -			   "to make it clean.");
> +			   "journal. You must boot into BeOS and mount this "
> +			   "volume to make it clean.");
>  		return BEFS_ERR;
>  	}
>  
> -- 
> 2.5.1
> 

Signed-off-by: Salah Triki <salah.triki@...il.com>

Thanx
Salah