linux-kernel - Re: [RFC][PATCH 3/4] arm64: dts: hikey: Add hikey support for syscon-reboot-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLVQrL52Z_A5yO+UfBWcva7gUvawq=gv+WWyV51rz2iuyw@mail.gmail.com>
Date:	Tue, 9 Aug 2016 21:58:20 -0700
From:	John Stultz <john.stultz@...aro.org>
To:	Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Andy Yan <andy.yan@...k-chips.com>,
	Haojian Zhuang <haojian.zhuang@...aro.org>,
	Guodong Xu <guodong.xu@...aro.org>,
	Wei Xu <xuwei5@...ilicon.com>,
	Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, devicetree@...r.kernel.org
Subject: Re: [RFC][PATCH 3/4] arm64: dts: hikey: Add hikey support for syscon-reboot-mode

On Tue, Aug 9, 2016 at 9:34 PM, Bjorn Andersson
<bjorn.andersson@...aro.org> wrote:
> On Mon 08 Aug 16:03 PDT 2016, John Stultz wrote:
>
> [..]
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> [..]
>>       memory@0 {
>>               device_type = "memory";
>>               reg = <0x00000000 0x00000000 0x00000000 0x05e00000>,
>> -                   <0x00000000 0x05f00000 0x00000000 0x00eff000>,
>> +                   <0x00000000 0x05f00000 0x00000000 0x00001000>,
>> +                   <0x00000000 0x05f02000 0x00000000 0x00efd000>,
>>                     <0x00000000 0x06e00000 0x00000000 0x0060f000>,
>>                     <0x00000000 0x07410000 0x00000000 0x36bf0000>;
>>       };
>
> As I said when talked about this, I don't think you should punch holes
> in the /memory node, but rather add these regions as no-map in a
> /reserved-memory node. But that's a unrelated matter.

Yea. I need to sync w/ Wei and Guodong to see about reworking all of
those to use /reserved-memory, but for now I'd like to stay in sync w/
how they have it setup.

>>
>> +     reboot-mode-syscon@...1000 {
>> +             compatible = "syscon", "simple-mfd";
>> +             reg = <0x0 0x05f01000 0x0 0x00001000>;
>> +
>> +             reboot-mode@0 {
>
> Drop the @0

Will do.


>
> Other than that:
> Acked-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Thanks!
-john