linux-kernel - Re: [PATCH] powerpc: move hmi.c to arch/powerpc/kvm/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87popftvgb.fsf@concordia.ellerman.id.au>
Date:	Thu, 11 Aug 2016 21:07:48 +1000
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Radim Krčmář <rkrcmar@...hat.com>,
	Paolo Bonzini <pbonzini@...hat.com>
Cc:	kvm@...r.kernel.org, Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, kvm-ppc@...r.kernel.org,
	Paul Mackerras <paulus@...ba.org>,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] powerpc: move hmi.c to arch/powerpc/kvm/

Michael Ellerman <mpe@...erman.id.au> writes:

> Radim Krčmář <rkrcmar@...hat.com> writes:
>
>> 2016-08-03 13:36+0200, Paolo Bonzini:
>>> hmi.c functions are unused unless sibling_subcore_state is nonzero, and
>>> that in turn happens only if KVM is in use.  So move the code to
>>> arch/powerpc/kvm/, putting it under CONFIG_KVM_BOOK3S_64_HANDLER
>>> rather than CONFIG_PPC_BOOK3S_64.  The sibling_subcore_state is also
>>> included in struct paca_struct only if KVM is supported by the kernel.
>>> 
>>> Cc: Paul Mackerras <paulus@...ba.org>
>>> Cc: Michael Ellerman <mpe@...erman.id.au>
>>> Cc: Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>
>>> Cc: linuxppc-dev@...ts.ozlabs.org
>>> Cc: kvm-ppc@...r.kernel.org
>>> Cc: kvm@...r.kernel.org
>>> Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
>>> ---
>>> 	It would be nice to have this in 4.8, to minimize any 4.9 conflicts.
>>> 	Build-tested only, with and without KVM enabled.
>>
>> If you agree with the change, would you prefer to have this patch merged
>> through the PowerPC tree?
>
> Yeah I'll pull it into my fixes branch.

And then I pulled it out again:

  (.text+0x157fc): undefined reference to `.wait_for_subcore_guest_exit'
  (.text+0x15834): undefined reference to `.wait_for_tb_resync'
  make[1]: *** [vmlinux] Error 1

http://kisskb.ellerman.id.au/kisskb/buildresult/12775422/

cheers