linux-kernel - Re: [PATCH 1/4] befs: dump inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160811140919.GA4140@pc>
Date:	Thu, 11 Aug 2016 15:09:19 +0100
From:	Salah Triki <salah.triki@...il.com>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	viro@...iv.linux.org.uk
Subject: Re: [PATCH 1/4] befs: dump inode_size superblock information

On Thu, Aug 11, 2016 at 11:03:47AM +0100, Luis de Bethencourt wrote:
> On 10/08/16 22:41, Salah Triki wrote:
> > On Tue, Aug 09, 2016 at 11:01:23PM +0100, Luis de Bethencourt wrote:
> >> befs_dump_super_block() wasn't giving the inode_size information when
> >> dumping all elements of the superblock. Add this element to have complete
> >> information of the superblock.
> >>
> >> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> >> ---
> >>
> >> Hi,
> >>
> >> This is a series of superblock information related changes.
> >>
> >> Thanks,
> >> Luis
> >>
> >>  fs/befs/debug.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/fs/befs/debug.c b/fs/befs/debug.c
> >> index 4de7cff..85c1339 100644
> >> --- a/fs/befs/debug.c
> >> +++ b/fs/befs/debug.c
> >> @@ -169,6 +169,7 @@ befs_dump_super_block(const struct super_block *sb, befs_super_block * sup)
> >>  
> >>  	befs_debug(sb, "  num_blocks %llu", fs64_to_cpu(sb, sup->num_blocks));
> >>  	befs_debug(sb, "  used_blocks %llu", fs64_to_cpu(sb, sup->used_blocks));
> >> +	befs_debug(sb, "  inode_size %u", fs32_to_cpu(sb, sup->inode_size));
> >>  
> >>  	befs_debug(sb, "  magic2 %08x", fs32_to_cpu(sb, sup->magic2));
> >>  	befs_debug(sb, "  blocks_per_ag %u",
> >> -- 
> >> 2.5.1
> >>
> > 
> > Signed-off-by: Salah Triki <salah.triki@...il.com>
> > 
> > Thanx
> > Salah
> > 
> 
> Hi Salah,
> 
> I prefer applying this series as a set. So will wait for your review of patch 2/4.
> 
> Let me know if you don't have time for it.
> 
> Thanks for the reviews,
> Luis

Hi Luis,

I am reviewing the patch 2/4 

regards,
Salah