[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdaY=k3MCEQbdrv+pF1XH5hpF8f7ncvW1VjMCBOfe8Poiw@mail.gmail.com>
Date: Thu, 11 Aug 2016 23:08:13 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Marc Zyngier <marc.zyngier@....com>
Cc: Jon Hunter <jonathanh@...dia.com>,
John Stultz <john.stultz@...aro.org>,
Thomas Gleixner <tglx@...utronix.de>,
lkml <linux-kernel@...r.kernel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [Regression] "irqdomain: Don't set type when mapping an IRQ"
breaks nexus7 gpio buttons
On Thu, Aug 11, 2016 at 2:46 PM, Marc Zyngier <marc.zyngier@....com> wrote:
> Nailed the sucker:
>
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index b4c1bc7..9d7284a 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -820,6 +820,18 @@ __irq_do_set_handler(struct irq_desc *desc, irq_flow_handler_t handle,
> desc->name = name;
>
> if (handle != handle_bad_irq && is_chained) {
> + int ret;
> +
> + ret = __irq_set_trigger(desc,
> + irqd_get_trigger_type(&desc->irq_data));
> + WARN_ON(ret);
> + /*
> + * This is beyond ugly: .set_type may have overridden
> + * the flow, not not knowing that we're dealing with a
> + * chained handler. Reset it here because we know
> + * better.
> + */
> + desc->handle_irq = handle;
> irq_settings_set_noprobe(desc);
> irq_settings_set_norequest(desc);
> irq_settings_set_nothread(desc);
>
> Linus, Jon: Can you please confirm this fixes your respective issues?
Yes, bullseye.
Tested-by: Linus Walleij <linus.walleij@...aro.org>
Thanks for your efforts!
Yours,
Linus Walleij
Powered by blists - more mailing lists