linux-kernel - Re: [PATCH] genirq: Correctly configure the trigger on chained interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZXAzipVrGSG1kvKvvGB_KGE0j-EmNwOaKyOdoz2Pxb7Q@mail.gmail.com>
Date:	Thu, 11 Aug 2016 23:09:17 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Marc Zyngier <marc.zyngier@....com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	John Stultz <john.stultz@...aro.org>,
	Jon Hunter <jonathanh@...dia.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] genirq: Correctly configure the trigger on chained interrupts

On Thu, Aug 11, 2016 at 5:55 PM, Marc Zyngier <marc.zyngier@....com> wrote:

> Commit 1e2a7d78499e ("irqdomain: Don't set type when mapping an IRQ")
> moved the trigger configuration call from the irqdomain mapping to
> the interrupt being actually requested.
>
> This patch failed to handle the case where we configure a chained
> interrupt, which doesn't get requested through the usual path.
>
> In order to solve this, let's call __irq_set_trigger just before
> starting the cascade interrupt. Special care must be taken to
> make the flow handler stick, as the .irq_set_type method could
> have reset it (it doesn't know we're dealing with a chained
> interrupt).
>
> Based on an initial patch by Jon Hunter.
>
> Fixes: 1e2a7d78499e ("irqdomain: Don't set type when mapping an IRQ")
> Reported-by: John Stultz <john.stultz@...aro.org>
> Reported-by: Linus Walleij <linus.walleij@...aro.org>
> Tested-by: John Stultz <john.stultz@...aro.org>
> Acked-by: Jon Hunter <jonathanh@...dia.com>
> Signed-off-by: Marc Zyngier <marc.zyngier@....com>

Tested-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij