lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Aug 2016 21:21:48 +0000 From: "Peter Feuerer" <peter@...e.net> To: "Baole Ni" <baolex.ni@...el.com>, dvhart@...radead.org, david.vrabel@...rix.com, jgross@...e.com, bhelgaas@...gle.com, m.chehab@...sung.com, pawel@...iak.com, m.szyprowski@...sung.com, kyungmin.park@...sung.com, k.kozlowski@...sung.com Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, chuansheng.liu@...el.com Subject: Re: [PATCH 0841/1285] Replace numeric parameter like 0444 with macro 2. August 2016 14:29 Uhr, "Baole Ni" <baolex.ni@...el.com> schrieb: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com> > Signed-off-by: Baole Ni <baolex.ni@...el.com> Acked-by: Peter Feuerer <peter@...e.net> > --- > drivers/platform/x86/acerhdf.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c > index 460fa67..a4706dd 100644 > --- a/drivers/platform/x86/acerhdf.c > +++ b/drivers/platform/x86/acerhdf.c > @@ -96,13 +96,13 @@ static struct platform_device *acerhdf_dev; > > module_param(kernelmode, uint, 0); > MODULE_PARM_DESC(kernelmode, "Kernel mode fan control on / off"); > -module_param(interval, uint, 0600); > +module_param(interval, uint, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(interval, "Polling interval of temperature check"); > -module_param(fanon, uint, 0600); > +module_param(fanon, uint, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(fanon, "Turn the fan on above this temperature"); > -module_param(fanoff, uint, 0600); > +module_param(fanoff, uint, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(fanoff, "Turn the fan off below this temperature"); > -module_param(verbose, uint, 0600); > +module_param(verbose, uint, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(verbose, "Enable verbose dmesg output"); > module_param_string(force_bios, force_bios, 16, 0); > MODULE_PARM_DESC(force_bios, "Force BIOS version and omit BIOS check"); > -- > 2.9.2 -- thanks, --peter;
Powered by blists - more mailing lists