linux-kernel - Re: [PATCH 0841/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160819200232.GE81374@f23x64.localdomain>
Date:   Fri, 19 Aug 2016 13:02:32 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Peter Feuerer <peter@...e.net>
Cc:     Baole Ni <baolex.ni@...el.com>, david.vrabel@...rix.com,
        jgross@...e.com, bhelgaas@...gle.com, m.chehab@...sung.com,
        pawel@...iak.com, m.szyprowski@...sung.com,
        kyungmin.park@...sung.com, k.kozlowski@...sung.com,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        chuansheng.liu@...el.com
Subject: Re: [PATCH 0841/1285] Replace numeric parameter like 0444 with macro

On Thu, Aug 11, 2016 at 09:21:48PM +0000, Peter Feuerer wrote:
> 2. August 2016 14:29 Uhr, "Baole Ni" <baolex.ni@...el.com> schrieb:
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
> > 
> > Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> > Signed-off-by: Baole Ni <baolex.ni@...el.com>
> 
> Acked-by: Peter Feuerer <peter@...e.net>

Due to objections elsewhere in the platform drivers subsystem, I have rejected
these patches as a group, leaving it to the authors to make the argument for
inclusion if they disagree with the decision.

-- 
Darren Hart
Intel Open Source Technology Center