linux-kernel - Re: [PATCH v5 2/2] Add support for SCT Write Same

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1y442pyx4.fsf@sermon.lab.mkp.net>
Date:	Thu, 11 Aug 2016 21:18:47 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Tom Yan <tom.ty89@...il.com>
Cc:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Shaun Tancheff <shaun.tancheff@...gate.com>,
	Shaun Tancheff <shaun@...cheff.com>, linux-ide@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>, Tejun Heo <tj@...nel.org>,
	Josh Bingaman <josh.bingaman@...gate.com>
Subject: Re: [PATCH v5 2/2] Add support for SCT Write Same

>>>>> "Tom" == Tom Yan <tom.ty89@...il.com> writes:

>> Many drives from different vendors were affected by this. So we'd
>> have to make multi block payloads an explicit opt-in like we did for
>> discard_zeroes_data. However, given that "big" discards are mainly
>> done synchronously when creating filesystems, I am not sure there is
>> any real benefit to this.

Tom> Probably. Perhaps it could make a difference upon deletion of some
Tom> really big files (though the logical sectors used may not be
Tom> continuous anyway).

Nope. And you've got the bio size limit getting in the way as well.

-- 
Martin K. Petersen	Oracle Linux Engineering