linux-kernel - Re: [PATCH v5 1/2] Use kmap_atomic when rewriting attached page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160811141334.GA16956@lst.de>
Date:	Thu, 11 Aug 2016 16:13:34 +0200
From:	Christoph Hellwig <hch@....de>
To:	Shaun Tancheff <shaun@...cheff.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@....de>, Tejun Heo <tj@...nel.org>,
	Josh Bingaman <josh.bingaman@...gate.com>,
	Shaun Tancheff <shaun.tancheff@...gate.com>
Subject: Re: [PATCH v5 1/2] Use kmap_atomic when rewriting attached page

> +static unsigned int ata_format_dsm_trim_descr(struct scatterlist *sg, u32 num,
> +					      u64 sector, u32 count)
> +{
> +	void *ptr = kmap_atomic(sg_page(sg));


Please use sg_copy_from_buffer to be safe against all corner cases.