linux-kernel - Re: [PATCH v10 10/11] serial: 8250_lpss: enable MSI for Intel Quark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Aug 2016 12:35:24 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Bryan O'Donoghue <pure.logic@...us-software.ie>,
	Peter Hurley <peter@...leysoftware.com>,
	linux-serial@...r.kernel.org, Vinod Koul <vinod.koul@...el.com>,
	linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	ismo.puustinen@...el.com,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>
Subject: Re: [PATCH v10 10/11] serial: 8250_lpss: enable MSI for Intel Quark

On Mon, 2016-08-15 at 10:04 +0100, Bryan O'Donoghue wrote:
> On Fri, 2016-08-12 at 19:01 +0300, Andy Shevchenko wrote:
> > 
> > Intel Quark SoC supports MSI for LPSS, in particular for UART.
> > Enable
> > MSI for
> > Intel Quark.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> >  drivers/tty/serial/8250/8250_lpss.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/drivers/tty/serial/8250/8250_lpss.c
> > b/drivers/tty/serial/8250/8250_lpss.c
> > index cad96ee..5ac291c 100644
> > --- a/drivers/tty/serial/8250/8250_lpss.c
> > +++ b/drivers/tty/serial/8250/8250_lpss.c
> > @@ -151,6 +151,17 @@ static int byt_serial_setup(struct lpss8250
> > *lpss, struct uart_port *port)
> >  	return 0;
> >  }
> >  
> > +static int qrk_serial_setup(struct lpss8250 *lpss, struct uart_port
> > *port)
> > +{
> > +	struct pci_dev *pdev = to_pci_dev(port->dev);
> > +
> > +	pci_enable_msi(pdev);
> > 
> 
> Andy,
> 
> ret = pci_enable_msi(dev);
> if (ret)
>     return ret;
> 
> once added please add

Why? MSI is optional. If we can't do that we just fall back to standard
IRQ signaling.

Okay, since recent APIs [1] I should use another call actually, i.e.
pci_alloc_irq_vectors().

[1] Documentation/PCI/MSI-HOWTO.txt

> 
> Reviewed-by: Bryan O'Donoghue <pure.logic@...us-software.ie>

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy