linux-kernel - Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+Ln22HWHRROhzVQo4ptsKr5xNyMh=dnuCO7FEG1BsinpPg8MQ@mail.gmail.com>
Date:	Mon, 15 Aug 2016 20:34:51 +0900
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	perr <strongbox8@...o.com>
Cc:	Krzysztof Kozłowski <k.kozlowski@...sung.com>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Kukjin Kim <kgene@...nel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler

Hi,

2016-08-15 19:17 GMT+09:00 perr <strongbox8@...o.com>:
> Because chained_irq_enter() has already called chip->irq_mask() and
> chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(),
> so it's not necessary to call chip->irq_*() here.
>
> Signed-off-by: perr <strongbox8@...o.com>
>
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>

Indeed, nice finding. Thanks!

Acked-by: Tomasz Figa <tomasz.figa@...il.com>

Best regards,
Tomasz