linux-kernel - Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Aug 2016 18:59:41 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	perr <strongbox8@...o.com>
Cc:	tomasz.figa@...il.com, k.kozlowski@...sung.com,
	s.nawrocki@...sung.com, linus.walleij@...aro.org, kgene@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler

On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote:
> Because chained_irq_enter() has already called chip->irq_mask() and
> chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(),
> so it's not necessary to call chip->irq_*() here.
> 
> Signed-off-by: perr <strongbox8@...o.com>
> 
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>


Looks correct so for the patch itself:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

However, your name "Perr" confuses me a little bit. For the
Signed-off-by statement, as mentioned in
Documentation/SubmittingPatches, a real name is required. The name
should match the author.

Would you be so kind as to use a full, real name? Unless Perr is your
full, real name... then sorry for the trouble.

Best regards,
Krzysztof