linux-kernel - Re: [PATCH v3 09/14] media: platform: pxa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87inv2qejl.fsf@belgarion.home>
Date:	Mon, 15 Aug 2016 16:42:38 +0200
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Hans Verkuil <hverkuil@...all.nl>
Cc:	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Jiri Kosina <trivial@...nel.org>, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH v3 09/14] media: platform: pxa_camera: add buffer sequencing

Hans Verkuil <hverkuil@...all.nl> writes:

> On 08/15/2016 03:26 PM, Robert Jarzmik wrote:
>> Robert Jarzmik <robert.jarzmik@...e.fr> writes:
>> I've seen no documentation on the rules applicable to this sequence number:
>>  - should it be reset if a "start streaming" operation occurs ?
>
> start_streaming is the recommended place for setting the counter to 0. It's what
> v4l2-compliance expects.
>
> It is not documented since 1) not every driver does this and 2) there may
> be cases where this behavior is not desired.
>
> That said, I have yet to see a driver where zeroing this in start_streaming
> is not appropriate.

Thanks for the information Hans, I'll modify this patch accordingly.

Cheers.

--
Robert