linux-kernel - Re: [PATCH 07/15] lustre: ->kss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160815165501.GA23625@kroah.com>
Date:	Mon, 15 Aug 2016 18:55:01 +0200
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Oleg Drokin <green@...uxhacker.ru>
Cc:	devel@...verdev.osuosl.org,
	Andreas Dilger <andreas.dilger@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Lustre Development List <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH 07/15] lustre: ->kss_scratch... are unused now

On Sat, Jul 23, 2016 at 02:37:04AM -0400, Oleg Drokin wrote:
> From: Al Viro <viro@...iv.linux.org.uk>
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---
>  drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
> index d5efb42..84a915c 100644
> --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
> +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h
> @@ -86,10 +86,6 @@ struct ksock_sched {				/* per scheduler state */
>  	int                     kss_nconns;     /* # connections assigned to
>  						 * this scheduler */
>  	struct ksock_sched_info *kss_info;	/* owner of it */
> -	union {
> -		struct bio_vec          kss_scratch_bvec[LNET_MAX_IOV];
> -		struct kvec             kss_scratch_iov[LNET_MAX_IOV];

kss_scratch_iov is still being used in the tree :(

Oleg, can you fix this up based on the current staging-testing branch
and resend the rest of this series?

Also, whenever you forward on patches to me, be sure to add your
signed-off-by to it, you forgot to do that on Al's patches...

thanks,

greg k-h