linux-kernel - Re: [PATCH 1/1 linux-next] hwrng: update Freescale i.MX RNGA Random Number Generator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <410285846.365138.1471280685355.open-xchange@webmail.nmp.proximus.be>
Date:	Mon, 15 Aug 2016 19:04:45 +0200 (CEST)
From:	Fabian Frederick <fabf@...net.be>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	linux-kernel@...r.kernel.org, Matt Mackall <mpm@...enic.com>
Subject: Re: [PATCH 1/1 linux-next] hwrng: update Freescale i.MX RNGA Random
 Number Generator



> On 15 August 2016 at 17:05 Arnd Bergmann <arnd@...db.de> wrote:
>
>
> On Friday 12 August 2016, Fabian Frederick wrote:
> > We can directly depend on SOC_IMX31 since
> > commit c9ee94965dce
> > ("ARM: imx: deconstruct mxc_rnga initialization")
> >
> > Signed-off-by: Fabian Frederick <fabf@...net.be>
>
> Did I cause a regression with my patch, without this change? If so, this
> should be
> marked
>
> Cc: stable@...r.kernel.org
> Fixes: c9ee94965dce ("ARM: imx: deconstruct mxc_rnga initialization")
>
> and the patch applied ASAP.

Thanks Arnd. Your patch brings the following regression:
CONFIG_HW_RANDOM_MXC_RNGA can't be switched on with an unknown symbol and
mxc-rnga.o will never build with
ARCH=arm make M=drivers/char/hw_random
Before your patch, HW_RANDOM_MXC_RNGA required ARCH_HAS_RNGA
which was based on IMX_HAVE_PLATFORM_MXC_RNGA  && ARCH_MXC
IMX_HAVE_PLATFORM_MXC_RNGA  was based on SOC_IMX31.
As I see SOC_IMX31 is selected by ARCH_MXC, my patch still seems ok and I can Cc
it for stable.

Regards,
Fabian

>
> > ---
> >  drivers/char/hw_random/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> > index 56ad5a59..8c0770b 100644
> > --- a/drivers/char/hw_random/Kconfig
> > +++ b/drivers/char/hw_random/Kconfig
> > @@ -244,7 +244,7 @@ config HW_RANDOM_TX4939
> > 
> >  config HW_RANDOM_MXC_RNGA
> >     tristate "Freescale i.MX RNGA Random Number Generator"
> > -   depends on ARCH_HAS_RNGA
> > +   depends on SOC_IMX31
> >     default HW_RANDOM
>
> It would be nice to add "|| COMPILE_TEST here", but that should probably be
> a separate patch, as we don't want to backport that or treat it as a bugfix.
>
>       Arnd