linux-kernel - Re: [PATCH 1/1 linux-next] hwrng: update Freescale i.MX RNGA Random Number Generator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160816095714.GF27042@gondor.apana.org.au>
Date:	Tue, 16 Aug 2016 17:57:14 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Fabian Frederick <fabf@...net.be>
Cc:	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	Matt Mackall <mpm@...enic.com>
Subject: Re: [PATCH 1/1 linux-next] hwrng: update Freescale i.MX RNGA Random
 Number Generator

On Mon, Aug 15, 2016 at 07:04:45PM +0200, Fabian Frederick wrote:
> 
> 
> > On 15 August 2016 at 17:05 Arnd Bergmann <arnd@...db.de> wrote:
> >
> >
> > On Friday 12 August 2016, Fabian Frederick wrote:
> > > We can directly depend on SOC_IMX31 since
> > > commit c9ee94965dce
> > > ("ARM: imx: deconstruct mxc_rnga initialization")
> > >
> > > Signed-off-by: Fabian Frederick <fabf@...net.be>
> >
> > Did I cause a regression with my patch, without this change? If so, this
> > should be
> > marked
> >
> > Cc: stable@...r.kernel.org
> > Fixes: c9ee94965dce ("ARM: imx: deconstruct mxc_rnga initialization")
> >
> > and the patch applied ASAP.
> 
> Thanks Arnd. Your patch brings the following regression:
> CONFIG_HW_RANDOM_MXC_RNGA can't be switched on with an unknown symbol and
> mxc-rnga.o will never build with
> ARCH=arm make M=drivers/char/hw_random
> Before your patch, HW_RANDOM_MXC_RNGA required ARCH_HAS_RNGA
> which was based on IMX_HAVE_PLATFORM_MXC_RNGA  && ARCH_MXC
> IMX_HAVE_PLATFORM_MXC_RNGA  was based on SOC_IMX31.
> As I see SOC_IMX31 is selected by ARCH_MXC, my patch still seems ok and I can Cc
> it for stable.

Please resubmit the patch to linux-crypto@...r.kernel.org.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt