linux-kernel - RE: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C246CAC1457055469EF09E3A7AC4E11A4A5E2756@XAP-PVEXMBX01.xlnx.xilinx.com>
Date:	Tue, 16 Aug 2016 06:30:00 +0000
From:	Appana Durga Kedareswara Rao <appana.durga.rao@...inx.com>
To:	Andrew Lunn <andrew@...n.ch>
CC:	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"mark.rutland@....com" <mark.rutland@....com>,
	Michal Simek <michals@...inx.com>,
	Soren Brinkmann <sorenb@...inx.com>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	"Punnaiah Choudary Kalluri" <punnaia@...inx.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: RE: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

Hi Andrew,

> 
> > Signed-off-by: Kedareswara rao Appana <appanad@...inx.com>
> > ---
> > Thanks a lot Andrew for your inputs.
> > Changes for v5:
> > --> Fixed return values in the probe as suggested by punnaiah.
> > --> Added a mask for the converter speed as suggested by punnaiah.
> > +/* Xilinx GMII2RGMII Converter driver
> > + *
> > + * Copyright (C) 2016 Xilinx, Inc.
> > + *
> > + * Author: Kedareswara rao Appana <appanad@...inx.com>
> 
> Not cool
> 
> https://github.com/lunn/linux/commit/03d375489ceb56e171056f44d0fe9c34ca
> 5a098e
> 
> Notice the
> 
> Not-Signed-off-by: Andrew Lunn <andrew@...n.ch>
> 
> and the Copyright i added?
> 
> In various emails i gave you the basic idea how this should be done, a framework
> of code, and then took your code which did not even compile and made the core
> of it work. This is as much my code as your code, so i expect my Copyright to be
> kept on this code. And since this is my code, i need to give a Signed-off-by,
> which i was not yet ready to give since the code was not complete or working.
> 
> Please put both my Copyright back and Not-Signed-Off-by back and post the
> next version as RFC. Once i'm happy this code is O.K, i will give you a Signed-off-
> by.

Sorry I should have been included your copyright.

I missed it...
I didn't included your SOF because.
AFAIK without explicit permission of the other person we shouldn't include SOF.
That's why I didn't included your SOF and thanked for your efforts after SOF.
Sorry if my understanding is wrong.
 
There are few comments for this patch series and I fixed it and sent the v6 version.
 V6 version of patch series already got merged on the net-next.

Sent the patch by updating the driver with your copy right 
"net: phy: Update copyright info".

Sorry for the noise will fix these type of issues next time onwards...

Regards,
Kedar.