linux-kernel - Re: [PATCH v2] ARM: Add missing newline terminators to kernel messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1471370496.4075.170.camel@perches.com>
Date:	Tue, 16 Aug 2016 11:01:36 -0700
From:	Joe Perches <joe@...ches.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Geert Uytterhoeven <geert+renesas@...der.be>,
	Russell King <linux@...linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ARM: Add missing newline terminators to kernel
 messages

On Tue, 2016-08-16 at 19:50 +0200, Geert Uytterhoeven wrote:
> Hi Joe,
> 
> On Tue, Aug 16, 2016 at 7:08 PM, Joe Perches <joe@...ches.com> wrote:
> > 
> > On Tue, 2016-08-16 at 15:40 +0200, Geert Uytterhoeven wrote:
> > > 
> > > Before commit 874f9c7da9a4acbc ("printk: create pr_<level>
> > > functions"),
> > > pr_*() calls without a trailing newline characters would be
> > > printed with
> > > a newline character appended, both on the console and in the
> > > output of
> > > the dmesg command.
> > Hey Geert.
> > 
> > This doesn't apply to -next as the pr_notice/pr_cont below is
> > properly changed to a single pr_notice.
> In which -next?
> 
> Not in next-20160816, where the patch applies cleanly.
> Also not in arm/for-next.

My mistake, I was in the wrong directory.
It doesn't apply to Linus' tree.

Still, it'd be slightly nicer to use a single
pr_notice than the pr_notice/pr_cont.

cheers, Joe