linux-kernel - Re: [PATCH 01/15 RESEND] staging: dgnc: remove redundant NULL checks in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160817062526.GA17218@kroah.com>
Date:	Wed, 17 Aug 2016 08:25:26 +0200
From:	Greg KH <gregkh@...uxfoundation.org>
To:	DaeSeok Youn <daeseok.youn@...il.com>
Cc:	Lidza Louina <lidza.louina@...il.com>,
	Mark Hounschell <markh@...pro.net>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>,
	devel <devel@...verdev.osuosl.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	kernel-janitors <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 01/15 RESEND] staging: dgnc: remove redundant NULL checks
 in

On Wed, Aug 17, 2016 at 10:05:03AM +0900, DaeSeok Youn wrote:
> 2016-08-16 2:05 GMT+09:00 Greg KH <gregkh@...uxfoundation.org>:
> > On Wed, Jul 06, 2016 at 03:11:13PM +0900, Daeseok Youn wrote:
> >> The dgnc_block_til_ready() is only used in dgnc_tty_open().
> >> The unit data(struct un_t) was stored into tty->driver_data in dgnc_tty_open().
> >> And also tty and un were tested about NULL so these variables doesn't
> >> need to check for NULL in dgnc_block_til_ready().
> >>
> >> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
> >> ---
> >> RESEND: This patch was not merged for a long time, if there is any reason
> >> why this patch could NOT be merged into staging tree, let me know.
> >> There were no comment for this patch.
> >> I cannot understand why this patch have to wait long time to merge.
> >> And I also sent emails to mailing-lists for reminding this patch...
> >> please let me know, what is the problem to merge this patch into staging tree.
> >
> > Please note, staging patches are at the bottom of my priority queue.
> > Combined with a vacation, conferences, and a merge window and there are
> > a lot of pending staging patches in my to-review queue.
> 
> That's Ok. but I took a long time to wait for merging my patches in
> this case. :-(

You are not alone.  And what's the rush?  These are just trivial staging
driver patches, it's not like you have the hardware for this device and
are needing these patches to get it to work, right?

thanks,

greg k-h