linux-kernel - Re: [PATCH v3 4/5] net: ethernet: ti: davinci_cpdma: move cpdma channel struct macroses to internals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18d62dfd-8e70-bc81-5b94-29612cdab82d@ti.com>
Date:	Wed, 17 Aug 2016 11:53:24 +0530
From:	Mugunthan V N <mugunthanvnm@...com>
To:	Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<grygorii.strashko@...com>
CC:	<linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	<nsekhar@...com>
Subject: Re: [PATCH v3 4/5] net: ethernet: ti: davinci_cpdma: move cpdma
 channel struct macroses to internals

On Tuesday 16 August 2016 04:55 AM, Ivan Khoronzhuk wrote:
> Keep the driver internals in C file. Currently it's not required for
> drivers to know rx or tx a channel is, except create function.
> So correct "channel create" function, and use all channel struct
> macroses only for internal use.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>

Reviewed-by: Mugunthan V N <mugunthanvnm@...com>

Regards
Mugunthan V N