linux-kernel - Re: [PATCH 1/2] ARM: dts: da850-lcdk: Audio support via simple-card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bc04130-0e0f-1c5d-43ad-3755b22295e5@ti.com>
Date:	Wed, 17 Aug 2016 17:02:13 +0530
From:	Sekhar Nori <nsekhar@...com>
To:	Karl Beldan <kbeldan@...libre.com>
CC:	<devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Russell King <linux@...linux.org.uk>,
	Kevin Hilman <khilman@...libre.com>,
	Karl Beldan <karl.beldan+oss@...il.com>,
	Peter Ujfalusi <peter.ujfalusi@...com>
Subject: Re: [PATCH 1/2] ARM: dts: da850-lcdk: Audio support via simple-card

On Wednesday 17 August 2016 04:03 PM, Karl Beldan wrote:
> On Wed, Aug 17, 2016 at 03:24:42PM +0530, Sekhar Nori wrote:
>> On Thursday 11 August 2016 01:38 AM, Karl Beldan wrote:
>>> The LCDK embeds a TLV320AIC3106 connected to the SoC McASP for analog
>>> audio. This relies on the 'dummy' regulator as the codec is always on.
>>> Quality is good with arecord -pipe- aplay on Line In/Line Out.
>>> The MIC path doesn't seem to work yet.
>>
>> I tested the patch and I could not get the MIC to work as well. I
>> suggest dropping the MIC path parts till that is debugged and root caused.
>>
> 
> Ok.
> 
>>> Signed-off-by: Karl Beldan <kbeldan@...libre.com>
>>> ---
>>>  arch/arm/boot/dts/da850-lcdk.dts | 75 ++++++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 75 insertions(+)
>>
>>> +&i2c0 {
>>> +	pinctrl-names = "default";
>>> +	pinctrl-0 = <&i2c0_pins>;
>>> +	clock-frequency = <100000>;
>>> +	status = "okay";
>>> +
>>> +	tlv320aic3106: tlv320aic3106@18 {
>>> +		#sound-dai-cells = <0>;
>>> +		compatible = "ti,tlv320aic3106";
>>> +		reg = <0x18>;
>>> +		status = "okay";
>>> +
>>> +		ai3x-micbias-vg = <MICBIAS_2_5V>;
>>
>> It will be nice to add the codec regulators as well (and that in turn
>> needs the PMIC to be populated). Although I wont insist on that since
>> the regulators are optional properties.
>>
> 
> In the patch comment I stated it relied on the dummy regulator as the
> codec is always on but maybe I should have been more precise: it is not
> out of convenience to keep things on, it is by HW design: I mentioned
> it in the comment of "ARM: dts: da850: Add basic DTS for the LCDK":
>  "the main PMIC, different and hard-wired on the LCDK (the LDOs and
>  DCDCs are always on)" after reviewing the schematics.
> I could add that in the patch comment.

I see. PMIC on the LCDK is not software configurable at all. I think
what you have in the patch comment is already okay. More explanation
wont harm though :)

Regards,
Sekhar