linux-kernel - Re: [PATCH v2 1/2] devicetree: Add vendor prefix for Shenzhen Sunchip Technology Co., Ltd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+a04Btup8m=HkJ4ccmoCiYLT1B1habm76W21b9cTtmJA@mail.gmail.com>
Date:	Wed, 17 Aug 2016 07:48:40 -0500
From:	Rob Herring <robh@...nel.org>
To:	Rask Ingemann Lambertsen <ccc94453@....cybercity.dk>
Cc:	Mark Rutland <mark.rutland@....com>,
	Russell King <linux@...linux.org.uk>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Chen-Yu Tsai <wens@...e.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/2] devicetree: Add vendor prefix for Shenzhen Sunchip
 Technology Co., Ltd

On Tue, Aug 16, 2016 at 1:28 PM, Rask Ingemann Lambertsen
<ccc94453@....cybercity.dk> wrote:
> On Tue, Aug 16, 2016 at 07:56:24AM -0500, Rob Herring wrote:
>> On Thu, Aug 11, 2016 at 10:11:51PM +0200, Rask Ingemann Lambertsen wrote:
>> >
>> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> > index 1992aa9..fbad2cea 100644
>> > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> > @@ -256,6 +256,7 @@ ste     ST-Ericsson
>> >  stericsson ST-Ericsson
>> >  syna       Synaptics Inc.
>> >  synology   Synology, Inc.
>> > +sunchip    Shenzhen Sunchip Technology Co., Ltd
>> >  SUNW       Sun Microsystems, Inc
>>
>> These are not in alphabetical order. Maybe someone thought uppercase
>> should be separate, but I don't. So please fix the ordering here moving
>> SUNW before syna.
>
> I'm new to this, so I could use a bit of guidance here. Is it OK if I
> send a follow-up patch to fix the ordering or should I send a patch to
> fix the ordering first, before the sunchip prefix is added?

For this, just doing it all in one patch is fine. If you want to do 2
patches, then fix SUNW first then add sunchip.

> I never considered the possibility that the list wouldn't be in
> alphabetical order to begin with, so the brain power went into deciding
> if uppercase should be sorted separately.

Even if uppercase is sorted after lowercase, you've got it in the wrong place.

Rob