linux-kernel - Re: [RESEND PATCH 1/1] bitops.h: move out get_count_order[_long]() from __KERNEL_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160817172056.GE2356@ZenIV.linux.org.uk>
Date:	Wed, 17 Aug 2016 18:20:56 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	zijun_hu <zijun_hu@...o.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH 1/1] bitops.h: move out get_count_order[_long]()
 from __KERNEL__ scope

On Tue, Aug 16, 2016 at 03:46:22PM +0800, zijun_hu wrote:
> From: zijun_hu <zijun_hu@....com>
> 
> move out get_count_order[_long]() definitions from scope limited
> by macro __KERNEL__
> 
> it not only make both functions available in wider region regardless
> of whether __KERNEL__ is defined but also keep original region for
> get_count_order() before the recent commit c513b4cd2fe9
> ("mm-vmalloc-fix-align-value-calculation-error-v2-fix-fix") 

What the hell is anything without __KERNEL__ doing with linux/bitops.h in
the first place?  IOW, why do we have those ifdefs at all?