linux-kernel - Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57B55FC3.8050302@cn.fujitsu.com>
Date:	Thu, 18 Aug 2016 15:12:03 +0800
From:	"Zhou, Wenjian/周文剑" 
	<zhouwj-fnst@...fujitsu.com>
To:	Dave Young <dyoung@...hat.com>, Joe Perches <joe@...ches.com>
CC:	<linux-kernel@...r.kernel.org>, <akpm@...ux-foundation.org>,
	<bhe@...hat.com>, <vgoyal@...hat.com>, <corbet@....net>,
	<kexec@...ts.infradead.org>, <linux-doc@...r.kernel.org>,
	<xlpang@...hat.com>
Subject: Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus

On 08/18/2016 02:47 PM, Dave Young wrote:
> On 08/17/16 at 07:36pm, Joe Perches wrote:
>> On Thu, 2016-08-18 at 10:31 +0800, Zhou Wenjian wrote:
>>> nr_cpus can help to save memory. So we should remind user of it.
>>
>> trivia:
>>> diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt
>> []
>>> @@ -390,9 +390,11 @@ Notes on loading the dump-capture kernel:
>>>   * Boot parameter "1" boots the dump-capture kernel into single-user
>>>     mode without networking. If you want networking, use "3".
>>>
>>> -* We generally don' have to bring up a SMP kernel just to capture the
>>> +* We generally don' have to bring up an SMP kernel just to capture the
>>
>> don't or do not
>>
>
> Use do not is better, also need replace 'We' with 'You' to be
> consistent with other part.
>
>

I think it's better to fix it in another patch,
for it doesn't have much relevance to the patch set.
I'll post it alone later.

-- 
Thanks
Zhou