linux-kernel - Re: [PATCH 1/1] rbtree: correct mask for extracting node's parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160818090116.GA25687@twins.programming.kicks-ass.net>
Date:	Thu, 18 Aug 2016 11:01:16 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	zijun_hu <zijun_hu@...o.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, dhowells@...hat.com,
	linux-kernel@...r.kernel.org, zijun_hu@....com
Subject: Re: [PATCH 1/1] rbtree: correct mask for extracting node's parent

On Thu, Aug 18, 2016 at 04:19:10PM +0800, zijun_hu wrote:
> From: zijun_hu <zijun_hu@....com>
> 
> for LP64 ABI, struct rb_node aligns at 8 bytes boundary due to
> sizeof(long) == 8 normally, so 0x07 should be used to extract
> node's parent rather than 0x03

Doesn't matter though, in practise. The remaining bits are always 0.