linux-kernel - Re: [PATCH 1/2] x86/smpboot: Check APIC ID before setting up default routing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160818094730.GA1967@gmail.com>
Date:	Thu, 18 Aug 2016 11:47:30 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Wei Jiangang <weijg.fnst@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, bp@...e.de
Subject: Re: [PATCH 1/2] x86/smpboot: Check APIC ID before setting up default
 routing


* Wei Jiangang <weijg.fnst@...fujitsu.com> wrote:

> Check the boot APIC ID firstly,
> and then setup the default routing of APIC looks better.
> 
> And move default_setup_apic_routing() close to apic_bsp_setup(),
> which staying in step with the codes in APIC_init_uniprocessor().
> 
> Signed-off-by: Wei Jiangang <weijg.fnst@...fujitsu.com>
> ---
>  arch/x86/kernel/smpboot.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

If it's not a bug then please clearly note so in the changelog and
explain why the change results in better code.

If it's fixing a bug/misfeature then please fix the changelog to
conform to the standard changelog style:

 - first describe the symptoms of the bug - how does a user notice? 

 - then describe how the code behaves today and how that is causing the bug

 - and then only describe how it's fixed.

Thanks,

        Ingo